ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
467 stars 221 forks source link

openPopupWindow still is used :) #935

Closed obsy closed 2 years ago

obsy commented 2 years ago

openPopupWindow function is removed by https://github.com/ericpaulbishop/gargoyle/pull/822 but it still exists in bandwidth.js :)

olekstomek commented 2 years ago

I can confirm problem on Gargoyle 1.13 and Gargoyle 1.12.

Uncaught ReferenceError: openPopupWindow is not defined at expand (bandwidth.js) at HTMLSpanElement.onclick (bandwidth.sh:337)

lantis1008 commented 2 years ago

Apologies for any inconvenience caused. I also backported it to 1.12 (if that is at all useful) and will ensure it will be brought forward into 1.15