search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
465 stars 222 forks source link

Fixed displaying DNS addresses #965

Closed obsy closed 1 year ago

obsy commented 1 year ago

Removing exactly the IP address, not a string of characters starting with that address. If the DNS address is in the same address class as LAN, it is removed from the list but should stay.

For example

echo "192.168.1.100" | grep -v '192.168.1.1'
(return nothing)

echo "192.168.1.100" | grep -v '192.168.1.1$'
192.168.1.100

Also please add these changes to other branch.

lantis1008 commented 1 year ago

Hey, we've got this picked up in https://github.com/ericpaulbishop/gargoyle/commit/09aef320909d614ec73ab41763db72eb0c20cfe2 I can merge to master if you wish, but it will cause a conflict later when i go to bring in 22.03 branch. Not a big deal it can be solved easily.

obsy commented 1 year ago

So no, keep this in 22.03 branch.