search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
465 stars 222 forks source link

Update wifi settings #980

Closed lukasz1992 closed 1 year ago

lukasz1992 commented 1 year ago

I propose quite big set of changes:

The first one is handling Wifi6 on 2.4GHz.

I think that some options should be dropped:

Some small fixes also attached:

I prepared branch for those all and I am open to discuss. I also gave a chance to stay at WiFi3, when (and only when) radio does not support WiFi4.

If any special case needs handling, remember that Gargoyle here works as overlay for OpenWrt, you can still tweak these settings by editing /etc/config/wireless by your own.

lantis1008 commented 1 year ago

Hey Lukas, thanks for the contribution. Really keen to check this out in detail and I'll get back to you.

lantis1008 commented 1 year ago

Thanks for the contribution @lukasz1992 . Unfortunately I can't accept the changes as is. Please find my feedback below. If you have any questions please ask. 5ca55ed - Enable WiFi 6 on 2.4GHz too, drop WiFi 2 settings Minor changes required before accepting

1831d4b - Get rid of Ad-hoc mode Accepted, no changes

38ab334 - Get rid of WEP encryption Minor changes required before accepting

e9c47f5 - Get rid of WPA version 1 Not accepted. Please remove this change. I understand that WPA is not recommended, however it is still supported upstream at this stage and I'd like to stay close to that.

2aad650 - Allow newer encryptions for guest/bridge Minor changes required before accepting

6dde1f5 - Drop support for WiFi 3 Not accepted. Please remove this change. There are still uses for G and A modes. I would accept another option (under Connection -> Advanced) to set a minimum client capability (_requiremode). I won't accept greenfield. I feel this will create issues with peoples networks that they don't understand and can't debug. Maybe in the future.

faa8a4f - Reorder mode list; Channel 149 is fine for 160MHz width Changes required before accepting

lukasz1992 commented 1 year ago

@lantis1008 Thank you very much for detailed feedback, I will try to make changes in this week in this PR.

1.

A: I can revert the changes, I see anyway that this static content could be empty, as it is not being used - the list is being generated anyway (basing on cached vars to instert channels) and static content from .sh file is being replaced anyway. So channel 14 appears if radio0 supports it I do not agree about channel 14. Keep in mind that with only user/web interface (and without access to SSH) you can not enable 802.11b, as OpenWrt disables it by default. Also channel 14 is allowed only in this scenario:

2.

A: 149 is a valid 160MHz channel. So do not limit channel 149 if cfg80211/mac80211 layer allows it. Channel 149 (160MHz) is fine in the USA (only), basing on this: https://en.wikipedia.org/wiki/List_of_WLAN_channels

I will patch my PR to your review in all other points.

lantis1008 commented 1 year ago

Thanks for that. Sure, you can drop 14. Please fix the other ordering issue. I agree that the content is dynamically generated anyway and so maybe should be blank to save a few previous bytes. I might consider this in the future.

Sure, 149 is fine 😃

lukasz1992 commented 1 year ago

@lantis1008 hi, please check again :) no work for Connection -> Advanced yet.

lantis1008 commented 1 year ago

Thanks for taking on these changes and the feedback