search

ericpaulbishop / gargoyle

Gargoyle Router Management Utility
http://www.gargoyle-router.com
465 stars 222 forks source link

Problem with Quotas in 1.14 #997

Closed mswit82 closed 4 months ago

mswit82 commented 5 months ago

The problem occurs when QoS is enabled. No traffic is sent to the "upload" class created for throttling purposes (with any quotas rule). All traffic goes to the default queue. The "Download" section appears to be working. (Static throttling when QoS is disabled does not work in both directions.)

lantis1008 commented 5 months ago

Please post your configuration that reproduces this issue.

mswit82 commented 5 months ago

Default installation on Edgerouter X, I also checked on x86. The same problem that did not occur in the previous version. I create one additional class in both the "upload" and "download" sections where I want to direct the throttled traffic. Then only the "download" section works correctly. It doesn't matter what type of "quota" is selected, in the "upload" direction the traffic to be throttled, goes to the default "normal" class.

lantis1008 commented 5 months ago

I’ve been able to reproduce both issues. I have a fix for both but I need to do a bit more testing.

mswit82 commented 5 months ago

Thank you. I'm surprised no one noticed this in the current version. I hope to restore full functionality in a future version.

lantis1008 commented 4 months ago

This should now be fixed. Unfortunately you will need to recompile the firmware to enjoy the full fix. If you just want to quickly fix the QoS issue, you can just delete or comment out the two lines in /etc/init.d/qos_gargoyle as per here: https://github.com/lantis1008/gargoyle/commit/dab78a4944da75011919b66688b13d1d5c965fb8#diff-8118e97b6791398a6984a4e87b7b0a57e95cbd5bc76af63990ff8528a153d935L512-L513

To fix the throttling without using QoS classes, you need to install sched-prio which you won't be able to do as it is a kernel module so must recompile. In addition there are changes to restore_quotas application.