search

ericpaulbishop / redmine_git_hosting

A ChiliProject/Redmine plugin which makes configuring your own git hosting easy.
186 stars 37 forks source link

Errors when directories have spaces in the name #128

Open AshleyRoll opened 12 years ago

AshleyRoll commented 12 years ago

I have RedMine 1.2.2-stable (mysql) and 0.4.2 of redmine_git_hosting.

I have a repository where there there folders with spaces in the names, eg: "Presentation Tier". When accessing the repository page in Redmine, I don't see commit data for these folders, and I can't click on the folder to explore its history or expand it.

In the logs (production.log) I get:

Processing RepositoriesController#show (for xxx.xxx.xxx.xxx at 2011-12-05 16:01:30) [GET] Parameters: {"action"=>"show", "id"=>"SOME_ID_HERE", "controller"=>"repositories"} The revision 'Application Tier' has a wrong format The revision 'Data Tier' has a wrong format The revision 'External Dependencies' has a wrong format The revision 'Presentation Tier' has a wrong format The revision 'Application Tier' has a wrong format The revision 'Data Tier' has a wrong format The revision 'External Dependencies' has a wrong format The revision 'Presentation Tier' has a wrong format Rendering template within layouts/base Rendering repositories/show

I have found that these are generated from lib/redmine/scm/adapters/git_adapter.rb.

There seems to be an issue with escaping paths with spaces in them.