search

ericpaulbishop / redmine_git_hosting

A ChiliProject/Redmine plugin which makes configuring your own git hosting easy.
185 stars 37 forks source link

Misc git hosting fixes #162

Open ciaranj opened 12 years ago

ciaranj commented 12 years ago

Some, miscellaneous (hopefully un-contentious) fixes/performance improvements.

ciaranj commented 12 years ago

Hmm , this isn't good to pull yet,1057899 is wrong. The sentiment is right, but the approach I've taken doesn't actually work (well it works once, then never again ;) ) Not really sure how best to fix it whilst remaining 'close' to your version of the project.

The primary difference in my fork was around how I managed the 'update_repositories' call, namely I did: 

https://github.com/ciaranj/redmine_git_hosting/commit/6392c2095a125ea44e74d463bb4e2ffb15d1226a

and 

https://github.com/ciaranj/redmine_git_hosting/commit/6aa8ea56329b35d2e1f947b71716ff7da56663fd

To wrap all requests to redmine and do the actual update_repositories call at the end of the request so we didn't repeatedly update the same project. ... I can't see a way around this if Observers are singletons (which they appear to be.)

I also can't understand why I'm the only one who seems to be seeing this issue :(