custom `capture` may diverge from upstream

ericphanson / Asciicast.jl

Easy REPL animations in READMEs, Documenter docs, and more!

https://ericphanson.github.io/Asciicast.jl/

Other

42 stars 0 forks source link

custom `capture` may diverge from upstream #8

Open ericphanson opened 3 years ago

ericphanson commented 3 years ago

the file https://github.com/ericphanson/Asciicast.jl/blob/6e708110fadf4b5c5b92a12142cac7fcaeed4809/src/capture.jl is modified from IOCapture.jl but we won't get any upstream fixes with this vendored implementation (and looking at the file, there were a lot of fixes over time!).

Not sure what to do here because I'm not sure if upstream would like some weird API around how to pull from the pipe.

ericphanson commented 11 months ago

in the two years since I filed this, there was one difference (an extra yield()) which I've added here. So, so far this hasn't been a huge maintenance burden.