Closed chriscoey closed 3 years ago
OK no CI run it seems. I tried running locally after deving TableTestSets, but TableTestSets wouldn't compile on julia 1.6.1 for me, so I couldn't run anything
No PR CI unfortunately, we just have to merge and hope 😬. Looks good to me though. https://github.com/ericphanson/TableTestSets.jl/pull/1 should fix the 1.6 error btw.
Results are up btw: https://ericphanson.github.io/ConvexTests.jl/dev/Hypatia/
if you want to adjust it any parameters feel free to do so (and please put them in the description like in https://github.com/ericphanson/ConvexTests.jl/blob/40378231a4899687097f03a58217aa2afacdfa2b/COSMO/test.jl#L5).
If you want to also run tests with BigFloat problems, you could mimic https://github.com/ericphanson/ConvexTests.jl/blob/40378231a4899687097f03a58217aa2afacdfa2b/Tulip/test.jl#L8. Note the test tolerances aren’t any stricter by default so it’s more checking that adding precision doesn’t make things worse rather than a real high-precision test.
fixes #5 I haven't run locally yet so let's see what happens!