ericphanson / ExplicitImports.jl

Developer tooling for Julia namespace management: detecting implicit imports, improper explicit imports, and improper qualified accesses
https://ericphanson.github.io/ExplicitImports.jl/
MIT License
62 stars 2 forks source link

Provide functionality to detect "improper qualified access" #50

Closed ericphanson closed 1 month ago

ericphanson commented 1 month ago

closes #48

I think I've got the rough functionality working:

julia> ExplicitImports.improper_qualified_names_nonrecursive(ExplicitImports)
1 issues with qualified names were found:
- `parent` has parentmodule AbstractTrees but it was accessed from ExplicitImports at /Users/eph/ExplicitImports/src/qualified_names.jl:78:21

It isn't clear to me whether or not what matters is parentmodule, which, or maybe in 1.11, ispublic... I might mark this experimental and choose to change the criteria later.

before merging, needs:

and possibly in a followup:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 90.60%. Comparing base (d46bc8e) to head (ddef68e).

Files Patch % Lines
src/qualified_names.jl 0.00% 44 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ========================================== - Coverage 96.47% 90.60% -5.87% ========================================== Files 5 6 +1 Lines 680 724 +44 ========================================== Hits 656 656 - Misses 24 68 +44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.