search

ericphanson / ExplicitImports.jl

Developer tooling for Julia namespace management: detecting implicit imports, improper explicit imports, and improper qualified accesses
https://ericphanson.github.io/ExplicitImports.jl/
MIT License
62 stars 2 forks source link

Properly detect function args as local variables #8

Closed ericphanson closed 4 months ago

ericphanson commented 4 months ago

Fixes #1 re-fixes https://github.com/ericphanson/ExplicitImports.jl/issues/2

WIP, still need to handle type parameters...

Based off of #7 which I'll merge first.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.17241% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 97.67%. Comparing base (8ac3119) to head (133bfe0).

Files Patch % Lines
src/parse_utilities.jl 89.70% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## ========================================== - Coverage 97.94% 97.67% -0.27% ========================================== Files 4 5 +1 Lines 389 430 +41 ========================================== + Hits 381 420 +39 - Misses 8 10 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericphanson commented 4 months ago

well, this got real complicated. I did some refactoring to make it more feasible, and then manually handle a zillion cases, but I think it's working