search

ericsink / SQLitePCL.raw

A Portable Class Library (PCL) for low-level (raw) access to SQLite
Apache License 2.0
525 stars 109 forks source link

Change ISQLite3Provider.sqlite3_blob_open() signature back to what it was in 2.0.4 ? #396

Closed ericsink closed 3 years ago

ericsink commented 3 years ago

Last param should still be out sqlite3_blob, not out IntPtr.

To avoid a breaking change.

dotnet/efcore#23952

bricelam commented 3 years ago

Possibly not needed. I forgot to update one of the packages. (Or rather Dependabot stopped sending PRs once its number of open PRs filled up.)

ericsink commented 3 years ago

Acknowledged. I might still change it back anyway, so I'm leaving this open for now.

ericsink commented 3 years ago

Note that leaving the param as out IntPtr makes it consistent with all the others, including sqlite3, sqlite3_backup, sqlite3_stmt, etc.

The question is whether the conversion from IntPtr to the SafeHandle is done automatically by the pinvoke layer or is done in raw.cs by calling things like sqlite3_blob.From(intptr).

ericsink commented 3 years ago

This was done in 8a00ff76