Expose a way to create a utf8z from a ReadOnlySpan<byte>

ericsink / SQLitePCL.raw

A Portable Class Library (PCL) for low-level (raw) access to SQLite

Apache License 2.0

525 stars 109 forks source link

Expose a way to create a utf8z from a ReadOnlySpan<byte> #399

Closed CyrusNajmabadi closed 3 years ago

CyrusNajmabadi commented 3 years ago

@ericsink I'm also thinking about exposing util.to_utf8_with_z as a static method off of utf8z (with a more appropriate .net name). Basically, it would just ensure that clients of the library agree with the library on exactly how a string should be encoded to be valid for you.

Would that be ok with you?

CyrusNajmabadi commented 3 years ago

@ericsink ?

ericsink commented 3 years ago

Yeah, stand by, I'm trying to catch up with this. :-)

ericsink commented 3 years ago

LGTM. In fact, you've gone rather above and beyond the call of duty here with the API comments, thanks.

The util.to_utf8_with_z change you mentioned would be fine too. Should I merge this PR now or wait for that piece?

CyrusNajmabadi commented 3 years ago

I'll add that piece.

CyrusNajmabadi commented 3 years ago

@ericsink ready.