search

ericsink / SQLitePCL.raw

A Portable Class Library (PCL) for low-level (raw) access to SQLite
Apache License 2.0
512 stars 106 forks source link

Enable new math functions? #416

Open bricelam opened 3 years ago

bricelam commented 3 years ago

Looks like there are some new math functions in SQLite 3.35.0. Should we add SQLITE_ENABLE_MATH_FUNCTIONS to the list of default defines?

https://github.com/ericsink/cb/blob/bd3ec0643c5297c05c765f04a28104e85b59dd0c/bld/cb.cs#L1065-L1072

ericsink commented 3 years ago

When I try integrating 3.35.x (soon), I do plan to try turning that on to see how it goes.

ericsink commented 3 years ago

(But I'm glad you logged this so we have a place to track status of the issue)

nbevans commented 1 year ago

Would be great to get this enabled in the next release. The CEILING function is desperately needed and shouldn't be excluded from the standard build IMO (though that's a quirk of SQLite not SQLitePCLRaw)

nbevans commented 1 year ago

Any chance of it @ericsink ?

I may be naive of what goes on in the SQLitePCL.raw lib builds but it seems highly unlikely that enabling this compile-time option would break anything?

The math functions are included in most builds of SQLite now but not SQLitePCL.raw yet :(

ericsink commented 1 year ago

Hmmm. That looks like it would be fairly straightforward to include those.

I'll take a look soon. A few things have piled up, and it seems like time to crank out another release.

ericsink commented 1 year ago

I had trouble getting the Android builds to link with the math libs, so for now, I released 2.1.5 without this fix, so I can get the Mac arm64 simulator support out there. Hopefully 2.1.6 with math functions will follow shortly.

ericsink commented 1 year ago

Just to remind myself and others about this issue: I've been a bit swamped, and still haven't figured out the problem with math libs linking on android.

bricelam commented 11 months ago

I got the CI passing in https://github.com/ericsink/cb/pull/17!

ericsink commented 11 months ago

Yay!

So it looks like the basic fix was to up the android API level higher.

Thanks!