ericsink / SQLitePCL.raw

A Portable Class Library (PCL) for low-level (raw) access to SQLite
Apache License 2.0
512 stars 106 forks source link

v2.1.7 #566

Closed ericsink closed 7 months ago

ericsink commented 7 months ago
utelle commented 7 months ago

Regarding the packages for SQLite3 Multiple Ciphers I have 2 comments/questions:

  1. Please add a proper README to the sqlite3mc packages (something like this README @bricelam and I prepared and which is suited for NuGet.org), not only a short package description. I think it is important to guide users of the new packages a bit.
  2. I see library packages SQLitePCLRaw.lib.e_sqlite3mc.androidand SQLitePCLRaw.lib.e_sqlite3mc.ios, but not SQLitePCLRaw.lib.e_sqlite3mc like for the other variants e_sqlite3 and e_sqlcipher. Is this intentional?
ericsink commented 7 months ago

SQLitePCLRaw.lib.e_sqlite3mc is present and working okay for me. Where are you seeing its absence?

Perhaps what you are seeing is that that directory is not present under src. I think that's because everything inside that directory is automatically generated, and it never got committed to the repo. In most places, I have been committing generated code to the repo, which is an uncommon and questionable practice.

Nonetheless, SQLitePCLRaw.lib.e_sqlite3mc does seem to get generated and built and it shows up in the resulting nupkgs directory.

utelle commented 7 months ago

SQLitePCLRaw.lib.e_sqlite3mc is present and working okay for me. Where are you seeing its absence?

Perhaps what you are seeing is that that directory is not present under src.

Yes, exactly.

I think that's because everything inside that directory is automatically generated, and it never got committed to the repo. In most places, I have been committing generated code to the repo, which is an uncommon and questionable practice.

Well, it is a bit confusing if some generated sources are in the repo and some not.

Nonetheless, SQLitePCLRaw.lib.e_sqlite3mc does seem to get generated and built and it shows up in the resulting nupkgs directory.

Ok. Thanks for the clarification.

ericsink commented 7 months ago

I grabbed that README and put it into the bundle_e_sqlite3mc package, which is the same thing that I saw had been done before.

utelle commented 7 months ago

I grabbed that README and put it into the bundle_e_sqlite3mc package, which is the same thing that I saw had been done before.

Thanks. According to @bricelam it should be enough to have the README in the bundle package. Maybe we should remove the version section from the README, because the version information is shown on the NuGet package webpage anyway and will correspond to the actual version number of your package workflow.

ericsink commented 7 months ago

Maybe we should remove the version section

Done

utelle commented 7 months ago

Maybe we should remove the version section

Done

Sorry, not yet completely. The line in the TOC referring to the version section, should be removed, too. TIA.

ericsink commented 7 months ago

@bricelam @utelle Do you see anything else that should be done w.r.t. sqlite3mc before I publish a 2.1.7 prerelease?

bricelam commented 7 months ago

LGTM

utelle commented 7 months ago

You may go ahead with the prerelease.

bricelam commented 7 months ago

I think that's because everything inside that directory is automatically generated, and it never got committed to the repo.

Correct. I only included the files I personally authored in the PR to make reviewing easier. I left out the ones generated during build.

ericsink commented 7 months ago

2.1.7-pre has been published on NuGet.

bricelam commented 7 months ago

Posted More SQLite Encryption in .NET on my blog. I'll also spread the word on social media.

utelle commented 7 months ago

grafik