Closed ericsink closed 7 months ago
Regarding the packages for SQLite3 Multiple Ciphers I have 2 comments/questions:
sqlite3mc
packages (something like this README @bricelam and I prepared and which is suited for NuGet.org), not only a short package description. I think it is important to guide users of the new packages a bit.SQLitePCLRaw.lib.e_sqlite3mc.android
and SQLitePCLRaw.lib.e_sqlite3mc.ios
, but not SQLitePCLRaw.lib.e_sqlite3mc
like for the other variants e_sqlite3
and e_sqlcipher
. Is this intentional?SQLitePCLRaw.lib.e_sqlite3mc
is present and working okay for me. Where are you seeing its absence?
Perhaps what you are seeing is that that directory is not present under src
. I think that's because everything inside that directory is automatically generated, and it never got committed to the repo. In most places, I have been committing generated code to the repo, which is an uncommon and questionable practice.
Nonetheless, SQLitePCLRaw.lib.e_sqlite3mc
does seem to get generated and built and it shows up in the resulting nupkgs
directory.
SQLitePCLRaw.lib.e_sqlite3mc
is present and working okay for me. Where are you seeing its absence?Perhaps what you are seeing is that that directory is not present under
src
.
Yes, exactly.
I think that's because everything inside that directory is automatically generated, and it never got committed to the repo. In most places, I have been committing generated code to the repo, which is an uncommon and questionable practice.
Well, it is a bit confusing if some generated sources are in the repo and some not.
Nonetheless,
SQLitePCLRaw.lib.e_sqlite3mc
does seem to get generated and built and it shows up in the resultingnupkgs
directory.
Ok. Thanks for the clarification.
I grabbed that README and put it into the bundle_e_sqlite3mc
package, which is the same thing that I saw had been done before.
I grabbed that README and put it into the
bundle_e_sqlite3mc
package, which is the same thing that I saw had been done before.
Thanks. According to @bricelam it should be enough to have the README in the bundle package. Maybe we should remove the version section from the README, because the version information is shown on the NuGet package webpage anyway and will correspond to the actual version number of your package workflow.
Maybe we should remove the version section
Done
Maybe we should remove the version section
Done
Sorry, not yet completely. The line in the TOC referring to the version section, should be removed, too. TIA.
@bricelam @utelle Do you see anything else that should be done w.r.t. sqlite3mc before I publish a 2.1.7 prerelease?
LGTM
You may go ahead with the prerelease.
I think that's because everything inside that directory is automatically generated, and it never got committed to the repo.
Correct. I only included the files I personally authored in the PR to make reviewing easier. I left out the ones generated during build.
2.1.7-pre has been published on NuGet.
Posted More SQLite Encryption in .NET on my blog. I'll also spread the word on social media.
In my SQLite3MultipleCiphers-NuGet @bricelam made quite some effort to
Is there a way to add this version information to the SQLitePCLRaw packages, too? IMHO it would be useful for users of the packages to easily find out which versions are bundled with the NuGet packages.
I opened the package SQLitePCLRaw.bundle_e_sqlite3mc
in the NuGet package explorer (see screenshot below) and there are 3 items flagged as missing. However, I don't know how important it is to fix these issue.
sqlite3_serialize/deserialize
, thanks to @Trinitek and @garthmzlinux-musl-s390x
, thanks to @uweigand