search

ericsink / SQLitePCL.raw

A Portable Class Library (PCL) for low-level (raw) access to SQLite
Apache License 2.0
512 stars 106 forks source link

Add additional TFM to remove dependency #587

Open thompson-tomo opened 4 months ago

thompson-tomo commented 4 months ago

Summary

I want there to be an additional TFM for the package so that the dependency on System.Memory can be removed and instead the framework rely upon

Proposal

Add a new TFM ie NetCoreApp 3 and make the system.Memory package dependeny on TFM so it is only included when needed.

ericsink commented 4 months ago

Since, netcoreapp3 is out of support, this change doesn't seem necessary.

thompson-tomo commented 4 months ago

@ericsink netcoreapp 3 is just an sample but it could be something higher ie net 5 or 6 & have on the older frameworks the additional dependency which is not needed.

ericsink commented 4 months ago

Oh, I think maybe I see what you're talking about. SQLitePCLRaw.core targets netstandard2.0, and it contains a package reference for System.Memory. If it targeted one of the .NET Core TFMs, it would (IIRC) only need System.Memory for .NET Framework and maybe classic Xamarin.

Am I understanding correctly?

thompson-tomo commented 4 months ago

Correct. Happy to submit a pr if u nominate a TFM. I did net core 3 as it is the oldest where it isn't needed.

ericsink commented 4 months ago

Looking over pending issues and saw I meant to add a comment to this one:

I do plan to include this change (or something similar), probably as part of an upcoming release that drops support for Xamarin classic. With several different packages in play, I'm pretty sure it'll be a little bit more complicated than just adding a TFM.

Thanks.