search

ericsink / cb

Apache License 2.0
14 stars 13 forks source link

Add sqlite3mc and e_sqlite3mc to build process #19

Closed utelle closed 7 months ago

utelle commented 7 months ago

Integrate SQLite3 Multiple Ciphers into SQLitePCLraw

bricelam commented 7 months ago

I'm just using the binaries for sqlite3mc in https://github.com/ericsink/SQLitePCL.raw/pull/563. Is there a difference between them and e_sqlite3mc?

utelle commented 7 months ago

I'm just using the binaries for sqlite3mc in ericsink/SQLitePCL.raw#563. Is there a difference between them and e_sqlite3mc?

Except for the name there is no difference.

The build files coming with SQLite3 Multiple Ciphers use the library name sqlite3mc. Therefore it may be better to use the name e_sqlite3mc in the .NET packages to avoid potential name clashes, if users install both.

ericsink commented 7 months ago

I am always a bit amazed when someone else works on cb.cs. It is not a thing of beauty.

utelle commented 7 months ago

I am always a bit amazed when someone else works on cb.cs. It is not a thing of beauty.

I have to admit that I chose a somewhat "quick&dirty" approach to make the code "work". IMHO the code should be cleaned up a bit, as soon as we have decided, which library name will be used for the NuGet packages - sqlite3mc or e_sqlite3mc.

Actually, I used a copy of the function write_e_sqlite3() as a template for write_e_sqlite3mc() and write_sqlite3mc() . Most likely the #if not ... #endif sections can be removed. Regarding white space either blanks or tabs should be used, not a mixture.