search

ericsink / cb

Apache License 2.0
14 stars 13 forks source link

Add static libraries for Emscripten (Wasm) #9

Closed bricelam closed 2 years ago

bricelam commented 2 years ago

I'm still working on the changes to SQLitePCLRaw, but I think this part is done and ready for review.

Emscripten supports faux dynamic linking via -shared and .so files, but at the end of the day, it's really just static linking via combined object files. The approach I've chosen (using .a files) seems more honest and is more consistent with the AOT platforms that are already supported.

Part of #4

/cc @ajcvickers

ajcvickers commented 2 years ago

@bricelam Who should look at this from the Microsoft side?

/cc @SteveSandersonMS @danmoseley

ericsink commented 2 years ago

@bricelam Let me know if you want help with the SQLitePCLRaw side of this. I've been busy in the code this week working on net6/xamarin support, so a lot of stuff is fresh in my mind. I'm also concerned that I may be moving things around while you are trying to work in there.

ericsink commented 2 years ago

Latest failure is probably my fault, caused by my recent changes. SQLitePCLRaw build needs .NET 6 now.

danmoseley commented 2 years ago

@lewing owns enscripten stuff at the platform level.

SteveSandersonMS commented 2 years ago

@bricelam Who should look at this from the Microsoft side?

I've looked at it, but this code looks quite specific to SQLite concerns rather than anything about dotnet.wasm/Blazor, so don't have any feedback about this PR. When we get to a PR that creates a NuGet package that embeds the NativeFileReference, I might be more useful :)

ericsink commented 2 years ago

@bricelam The build.yml in the master branch now contains attempted fixes for the failure of the test run that happened on this PR.

ericsink commented 2 years ago

@bricelam I assume you are ready for this to be merged?

bricelam commented 2 years ago

Yep. I also just opened a PR for the packaging changes.