search

ericsomdahl / python-bittrex

Python bindings for bittrex
MIT License
585 stars 283 forks source link

Inconsistent Naming Convention `get_market_summaries` and `get_marketsummary` #125

Closed siderealex closed 6 years ago

siderealex commented 6 years ago

This I guess is a question of coding style, but it seems to me that the functions get_market_summaries and get_marketsummary are inconsistently named...

I propose that a more consistent naming convention is either [get_market_summaries, get_market_summary], or [get_marketsummaries, get_marketsummary]

robaleman commented 6 years ago

I noticed that as well; get_market_summary +get_market_summaries seems to be the one that's more consistent with the current naming convention

ericsomdahl commented 6 years ago

I'm ok with this. PRs are welcome

siderealex commented 6 years ago

Happy to submit a PR, thanks!

skyl commented 6 years ago

Looks like this is merged. Reopen if I'm wrong.