search

ericsomdahl / python-bittrex

Python bindings for bittrex
MIT License
585 stars 283 forks source link

For Python 3, fixed an issue where urllib has no attribute 'urlencode' #139

Closed ReverseSweep closed 6 years ago

ReverseSweep commented 6 years ago

I am not too sure if it was planned for this module to work in Python 3 but I am able to use the module with Python 3 after making these changes. (only the public api functions work, any functions that require the private api gives 'INVALID_SIGNATURE')

ericsomdahl commented 6 years ago

@ReverseSweep this code is un-mergeable. It appears to be based off of an ancient fork (https://github.com/panchr/python-bittrex) so not updated since 2015. It also solves a problem that no longer exists.

There are plenty of real issues in the library and your future contributions are always welcome.