search

ericssmith / scalafx

Automatically exported from code.google.com/p/scalafx
Other
0 stars 0 forks source link

[pull req] For observable collections, expose underlying JavaFX *ChangeListener objects #111

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I have written a change that exposes the observable collections' underlying 
JavaFX (Map|Set|List)ChangeListener objects for their 'onChange' methods. The 
key benefit of doing this is that one can now combine the convenience of 
ScalaFX's change events with the useful semantics of JavaFX's 
Weak(Map|Set|List)ChangeListener classes.

I have committed this to my clone repository 
<http://code.google.com/r/argvminusone-scalafx/>, marked with the bookmark 
'collections-expose-listeners'. Please consider pulling it. Thanks!

Original issue reported on code.google.com by argv.min...@gmail.com on 26 Nov 2013 at 5:45

GoogleCodeExporter commented 9 years ago 
Alex,

In the current shape, your commit   
https://code.google.com/r/argvminusone-scalafx/source/detail?r=0154731da10058143
c2737c00b4720c62a45eb65&name=collections-expose-listeners

cannot be merged into the main repository. You used `stable` branch that is 
only used for releases, development is done on the `default` branch. 

You will also need to provide tests for the new functionality and demos that 
will illustrate benefits of the proposed contributions. Even before that, can 
you elaborate what deficiency in the current ScalaFX API you are addressing? 
Why this change is needed?

Original comment by jpsacha on 27 Nov 2013 at 4:42

GoogleCodeExporter commented 9 years ago 
On further consideration, it seems to me that this change wasn't such a good 
idea. I have scheduled the linked source repository. Please close this bug 
report. I will not bother you again.

Original comment by argv.min...@gmail.com on 27 Nov 2013 at 8:46

GoogleCodeExporter commented 9 years ago

Original comment by jpsacha on 30 Nov 2013 at 5:50