search

erictapen / typst-invoice

A Typst template for generating invoices
MIT No Attribution
43 stars 8 forks source link

Feature: Option to add a signature #2

Closed ikelax closed 1 month ago

ikelax commented 1 month ago

Closes #1.

@erictapen Shall I also bump the version and/or adjust the template?

erictapen commented 1 month ago

Thanks, I'll bump the version. Do you happen to have an example signature that we could use in the main.typ?

ikelax commented 1 month ago

Unfortunately, I do not have one. However, I just found this website.

erictapen commented 1 month ago

I ended up changing the API for defining signatures actually, as I had trouble providing the correct path to the image file.

I personally chose a style that will make the signature a little to big, as if it was written on top of the printout. What do you think?

erictapen commented 1 month ago

Release is in progress: https://github.com/typst/packages/pull/986

ikelax commented 1 month ago

I ended up changing the API for defining signatures actually, as I had trouble providing the correct path to the image file.

I personally chose a style that will make the signature a little to big, as if it was written on top of the printout. What do you think?

It looks fine to me. I will test it this evening and (hopefully remind to) tell you how I like it in practice :)