search

erictleung / pixarfilms

:movie_camera: R data package to explore Pixar films, the people, and reception data
https://erictleung.com/pixarfilms
Creative Commons Zero v1.0 Universal
15 stars 4 forks source link

Failure with dev tibble #19

Closed krlmlr closed 3 years ago

krlmlr commented 3 years ago

A recent change in tibble 3.1.3 breaks output tests in this package, I'd like to release to CRAN soon. An easy workaround is to change this to snapshot tests which are ignored on CRAN, however this requires all tests to be compatible with testthat edition 3.

erictleung commented 3 years ago

Thanks @krlmlr for letting me know! I'll try to make some time to make this update. I've noticed that Hadley's {babynames} package made some similar changes and I hope to emulate some of that code https://github.com/hadley/babynames.

erictleung commented 3 years ago

Closed by https://github.com/erictleung/pixarfilms/commit/1eae5be2642e89443cf1d874874023c9bc034a1c