search

ericvaandering / DocDB

Working repository for DocDB
25 stars 20 forks source link

Problems using undefined database handles #56

Closed ericvaandering closed 6 years ago

ericvaandering commented 6 years ago

Several places:

Administer Document Type shows "internal server error" for incorrect username/password. (unknown where)

ExternalDocDBAdministerForm: If put in incorrect username/password, doesn't display same error message as the others (to say that should check that they have the right admin username and password). Says instead: "Can't call method "prepare" without a package or object reference at SecuritySQL.pm line 32." (or line 37 or 41)

SSO TopicAdminister, EventAdminister: When put in incorrect username/password, has the desired "incorrect username/password" message. But after that still shows "Software Error: Can't call method "prepare" without a package or object reference at FNALSSOUtilities.pm line 85." For the other admin functions, it shows the desired "incorrect username/password" instead of the "software error".)

ericvaandering commented 6 years ago

These issues are only fixed on the SSO branch. Some of the line numbers imply you are testing this in the 889 branch only.

The last paragraph is kind of unclear what's going on. I tweaked things a bit so that I hope it is better/fixed, but I can't see the problem.

ericvaandering commented 6 years ago

So please retest with the latest SSO branch and see if there are still problems.

lauramengel commented 6 years ago

The Admin Doc Type issues is from DocTypeAdminister:

I believe I tested the issues in the fnalsso version (not 889), but I'll try it again with the new fnalsso version I got today.

lauramengel commented 6 years ago

Hi. I did a git pull this morning on DocDB fnal sso version and re-tested with that and got the same behavior for all 3 items as I originally posted (for item #56 RE undefined DB handles).

Instructions for reproducing the Administer Document Type "internal server error" are in the comment above for Git #56.

ericvaandering commented 6 years ago

These should be fixed in the latest FNAL_SSO branch. There were a couple of subtle issues

lauramengel commented 6 years ago

Hi. All 3 of these are fixed now (no "internal server errors" or software errors, just the message to let them know they need to use the correct admin username and password. Thanks!