search

ericvaandering / DocDB

Working repository for DocDB
25 stars 18 forks source link

public link on document page versions area, even when no public version of doc #74

Closed lauramengel closed 6 years ago

lauramengel commented 6 years ago

On a document, in the box on the right that lists versions, under "Quick Links" there is a link to "Public Version" even if there is not a public version of that document. If you click on it, you get an error "There were fatal errors processing your request: You do not have permission to view this document (or it does not exist)."

ericvaandering commented 6 years ago

Want to try the branch remove_public_link? That should fix it, but this branch can't be used with SSO, so it's not so easy for me to test.

Eric

lauramengel commented 6 years ago

Ok. The public link does not show up if all versions of the doc are private. The public link does show up and work if all versions of the doc are public. The public link goes to the latest version of the doc.

However, if a doc has version 1 public and version 2 private, the public link does not show up in the "Quick Links" area on either version 1 or 2.

Maybe this case wasn't meant to show the public link, in which case we can close this (since no error to user anymore).

If this case was meant to show the link to the latest public version, we could move it to 8.8.10 or go another round, your choice. I do not think this is a show stopper.

ericvaandering commented 6 years ago

The current behavior appears to be the original intent (there was an actual bug). Showing a link to the most recent public version seems like a nice enhancement to consider for 8.8.10

On Jun 13, 2018, at 10:09 AM, lauramengel notifications@github.com wrote:

Ok. The public link does not show up if all versions of the doc are private. The public link does show up and work if all versions of the doc are public. The public link goes to the latest version of the doc.

However, if a doc has version 1 public and version 2 private, the public link does not show up in the "Quick Links" area on either version 1 or 2.

Maybe this case wasn't meant to show the public link, in which case we can close this (since no error to user anymore).

If this case was meant to show the link to the latest public version, we could move it to 8.8.10 or go another round, your choice. I do not think this is a show stopper.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ericvaandering_DocDB_issues_74-23issuecomment-2D396972632&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=EHaoB-POFWGrYFvPXoj1bQ&m=j3AeVTslZ7pcsct9F1aUSu-E4sqiJT7lLpsDlRblNpw&s=ai5idUYRPM-Am9S6hyR3hSvLTewgLOaFTqrPqqMtmI0&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABmEruynqHYhmUCffmhcuse8dIt10bwqks5t8SskgaJpZM4UlKrn&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=EHaoB-POFWGrYFvPXoj1bQ&m=j3AeVTslZ7pcsct9F1aUSu-E4sqiJT7lLpsDlRblNpw&s=7Avl5ezAGjn67nknXv9cjGW5ERuMP7Y_PWgagc4gjCA&e=.

lauramengel commented 6 years ago

Ok. I will close this then and put in my notes this could be an enhancement for later.

So then this just needs to get into the final code we'll use.

lauramengel commented 6 years ago

I meant the fix (not the enhancement) just needs to get in the final code we'll use for this release.

ericvaandering commented 6 years ago

Yup. It's merged into the 8.8.9 branch. The SSO stuff will be merged into the same branch and that will be merged into master. I'm doing it this way to try to isolate the SSO related stuff into one pull request/merge commit. I'm not 100% consistent with that and it will be a MASSIVE PR, but oh well.

I can always rebase to make FNAL_SSO reflective of everything in the final version, but that causes issues with having to reset which version you're using, so I want to do that infrequently.