search

ericvaandering / DocDB

Working repository for DocDB
25 stars 20 forks source link

Remove signature button shown for user after removed "cansign" from account #78

Closed lauramengel closed 6 years ago

lauramengel commented 6 years ago

Consider adding check to not show "sign document" or "remove signature" buttons if the designated account either (or both)

ericvaandering commented 6 years ago

Want to try it now? That and #77 should be fixed in the latest SSO branch.

The sign button should only appear if it's the correct user viewing it, so did you test the case where it is assigned to a user that doesn't have signature authority? From the title, I'm guessing yes.

lauramengel commented 6 years ago

did you test the case where it is assigned to a user that doesn't have signature authority? From the title, I'm guessing yes.

Yes. I needed to remove sign privileges for testing something else and then saw the remove button was still there.

lauramengel commented 6 years ago

This is fixed. Closing issue. Add and remove signature buttons appear if the designated signer has cansign. Neither button appears if the designated signer does not have cansign.