search

ericvitale / ST-LIFX-Group-of-Groups

Allows you to create a device based on a set of LIFX groups. If you have a group called "Kitchen" and a group called "Dining Room", you can create a group of groups called "First Floor" (or whatever) and add the two LIFX groups to it. You can treat the two groups as a single device. This handles up to 10 groups per device.
Apache License 2.0
5 stars 10 forks source link

Looping issue with retrying when lights are offline. #1

Open joelegg opened 6 years ago

joelegg commented 6 years ago

This seems to be an issue still. If any light is offline in the group, the app is sending commands every few minutes to the lights.

This device type keeps my st setup really neat. i'd be happy to donate for your time to look at fixing this.

ericvitale commented 6 years ago

No need to donate. It's been a while since I've had to tweak this code, but that is working as designed because one of the bulbs is not on, it thinks it should. If you want to make try a temporary fix for now you can comment out the following line of code on your installation in SmartThings. I think this will fix it... Maybe, lol.

https://github.com/ericvitale/ST-LIFX-Group-of-Groups/blob/master/devicetypes/ericvitale/lifx-group-of-groups.src/lifx-group-of-groups.groovy#L650

joelegg commented 6 years ago

thank you will give it a go.

joelegg commented 6 years ago

setup and working - it still seems to be continually changing the temp and saturation etc.

`

Date Source Type Name Value User Displayed Text
2018-07-11 11:29:30.503 AM AESTmoments ago DEVICE   saturation 0.21   Kitchen Lights Group saturation is 0.21
2018-07-11 11:29:30.490 AM AESTmoments ago DEVICE   hue 49.22   Kitchen Lights Group hue is 49.22
2018-07-11 11:29:30.436 AM AESTmoments ago DEVICE   colorTemperature 2500   Kitchen Lights Group color temperature is 2500
2018-07-11 11:29:30.381 AM AESTmoments ago DEVICE   hue 39.38   Kitchen Lights Group hue is 39.38
2018-07-11 11:29:30.327 AM AESTmoments ago DEVICE   saturation 0.36   Kitchen Lights Group saturation is 0.36
2018-07-11 11:29:30.315 AM AESTmoments ago DEVICE   hue 41.0   Kitchen Lights Group hue is 41.0
2018-07-11 11:29:30.240 AM AESTmoments ago DEVICE   colorTemperature 9000   Kitchen Lights Group color temperature is 9000
2018-07-11 11:28:30.692 AM AESTmoments ago DEVICE   saturation 0.21   Kitchen Lights Group saturation is 0.21
2018-07-11 11:28:30.684 AM AESTmoments ago DEVICE   hue 49.22   Kitchen Lights Group hue is 49.22
2018-07-11 11:28:30.651 AM AESTmoments ago DEVICE   colorTemperature 2500   Kitchen Lights Group color temperature is 2500
2018-07-11 11:28:30.615 AM AESTmoments ago DEVICE   hue 39.38   Kitchen Lights Group hue is 39.38
2018-07-11 11:28:30.584 AM AESTmoments ago DEVICE   saturation 0.36   Kitchen Lights Group saturation is 0.36
2018-07-11 11:28:30.574 AM AESTmoments ago DEVICE   hue 41.0   Kitchen Lights Group hue is 41.0
2018-07-11 11:28:30.536 AM AESTmoments ago DEVICE   colorTemperature 9000   Kitchen Lights Group color temperature is 9000
2018-07-11 11:27:30.616 AM AESTmoments ago DEVICE   saturation 0.21   Kitchen Lights Group saturation is 0.21
2018-07-11 11:27:30.605 AM AESTmoments ago DEVICE   hue 49.22   Kitchen Lights Group hue is 49.22
2018-07-11 11:27:30.563 AM AESTmoments ago DEVICE   colorTemperature 2500   Kitchen Lights Group color temperature is 2500
2018-07-11 11:27:30.515 AM AESTmoments ago DEVICE   hue 39.38   Kitchen Lights Group hue is 39.38
2018-07-11 11:27:30.473 AM AESTmoments ago DEVICE   saturation 0.36   Kitchen Lights Group saturation is 0.36
2018-07-11 11:27:30.462 AM AESTmoments ago DEVICE   hue 41.0   Kitchen Lights Group hue is 41.0
2018-07-11 11:27:30.410 AM AESTmoments ago DEVICE   colorTemperature 9000   Kitchen Lights Group color temperature is 9000
2018-07-11 11:26:31.041 AM AESTmoments ago DEVICE   saturation 0.21   Kitchen Lights Group saturation is 0.21
2018-07-11 11:26:31.026 AM AESTmoments ago DEVICE   hue 49.22   Kitchen Lights Group hue is 49.22
2018-07-11 11:26:30.978 AM AESTmoments ago DEVICE   colorTemperature 2500   Kitchen Lights Group color temperature is 2500
2018-07-11 11:26:30.922 AM AESTmoments ago DEVICE   hue 39.38   Kitchen Lights Group hue is 39.38
2018-07-11 11:26:30.875 AM AESTmoments ago DEVICE   saturation 0.36   Kitchen Lights Group saturation is 0.36
2018-07-11 11:26:30.862 AM AESTmoments ago DEVICE   hue 41.0   Kitchen Lights Group hue is 41.0
2018-07-11 11:26:30.811 AM AESTmoments ago DEVICE   colorTemperature 9000   Kitchen Lights Group color temperature is 9000
2018-07-11 11:25:32.256 AM AESTmoments ago DEVICE   saturation 0.21   Kitchen Lights Group saturation is 0.21
2018-07-11 11:25:32.244 AM AESTmoments ago DEVICE   hue 49.22   Kitchen Lights Group hue is 49.22
2018-07-11 11:25:32.199 AM AESTmoments ago DEVICE   colorTemperature 2500   Kitchen Lights Group color temperature is 2500
2018-07-11 11:25:32.167 AM AESTmoments ago DEVICE   level 90   Kitchen Lights Group level is 90
2018-07-11 11:25:32.142 AM AESTmoments ago DEVICE   hue 39.38   Kitchen Lights Group hue is 39.38
2018-07-11 11:25:32.110 AM AESTmoments ago DEVICE   level 27   Kitchen Lights Group level is 27
2018-07-11 11:25:32.079 AM AESTmoments ago DEVICE   saturation 0.36   Kitchen Lights Group saturation is 0.36
2018-07-11 11:25:32.067 AM AESTmoments ago DEVICE   hue 41.0   Kitchen Lights Group hue is 41.0
2018-07-11 11:25:17.560 AM AEST5 minutes ago DEVICE   switch on   Kitchen Lights Group switch is on

`

ericvitale commented 6 years ago

Ok. I just re-read your first comment... One bulb is offline or just off? Are you sure you are using the latest code? I had this issue a while back where it was stuck in a infinite loop when a bulb was offline, but fixed it...

ericvitale commented 6 years ago

1.3.4 has the fix.

joelegg commented 6 years ago

yep i'm on 1.3.4 (i noted that you commented you fixed that issue) but i still seem to be getting regular calls to the group - see log I just attached.

On Wed, Jul 11, 2018 at 11:36 AM ericvitale notifications@github.com wrote:

1.3.4 has the fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericvitale/ST-LIFX-Group-of-Groups/issues/1#issuecomment-404016855, or mute the thread https://github.com/notifications/unsubscribe-auth/AD62ImbvAWNwR8KFw_eH7RLM6E3J-kaRks5uFVatgaJpZM4VKHcn .

joelegg commented 6 years ago

infinite loop when a bulb was offline, but fixed it...

yep I had this issue also even on 1.3.4 tho. i checked and saw your comment which is why i was confused it was happening. but it could be a new bug i'm not sure - let me know what you think of how it's updating the saturation and levels' constantly. the bulb is not being updated externally.

ericvitale commented 6 years ago

Any chance you can set the devices log level to debug and capture the logs directly from the SmartThings IDE? Know how to do that?

joelegg commented 6 years ago

yep will do now

On Wed, Jul 11, 2018 at 11:51 AM ericvitale notifications@github.com wrote:

Any chance you can set the devices log level to debug and capture the logs directly from the SmartThings IDE? Know how to do that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericvitale/ST-LIFX-Group-of-Groups/issues/1#issuecomment-404019102, or mute the thread https://github.com/notifications/unsubscribe-auth/AD62IsXAXiRTK2fiWqStppksxBhXwb3Hks5uFVoJgaJpZM4VKHcn .

ericvitale commented 6 years ago

Also I just looked. I’m running 1.3.6 locally. I must have forgot to commit after testing. That was in October. I’ll commit in 10-15 min. I noticed your time zone is AEST... in Australia?

joelegg commented 6 years ago

yeah i'm in melbourne 1.3.6? selfish! :)

On Wed, Jul 11, 2018 at 11:55 AM ericvitale notifications@github.com wrote:

Also I just looked. I’m running 1.3.6 locally. I must have forgot to commit after testing. That was in October. I’ll commit in 10-15 min. I noticed your time zone is AEST... in Australia?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericvitale/ST-LIFX-Group-of-Groups/issues/1#issuecomment-404019762, or mute the thread https://github.com/notifications/unsubscribe-auth/AD62IvBoNhPglUxVJY0YX95du9w5_Z8Qks5uFVsDgaJpZM4VKHcn .

joelegg commented 6 years ago

fe43e554-ede5-472e-8fd3-c4a367713a74 11:55:34: debug LIFX-GoG -- Kitchen Lights Group -- Response [[product:[company:LIFX, name:LIFX GU10, capabilities:[max_kelvin:9000, has_multizone:false, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_gu10], brightness:0.8999923704890517, id:d073d530ce61, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0, kelvin:9000, hue:49.9995422293431], connected:true, power:on, label:Kitchen 97, uuid:021c6db3-1640-48e1-8f3c-3d1361a9a3d2, last_seen:2018-07-11T01:55:33Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], seconds_since_seen:0], [product:[company:LIFX, name:LIFX Z, capabilities:[max_kelvin:9000, has_multizone:true, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_z], brightness:0.8999923704890517, id:d073d5272af9, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0.359990844586862, kelvin:3500, hue:40.99610894941634], connected:true, power:on, label:Oven Strip, uuid:02d348e4-e29d-46ea-bb63-bb4501a890d3, last_seen:2018-07-11T01:55:33Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], zones:[count:14, zones:[[brightness:0.9, saturation:0.36, kelvin:3500, hue:41, zone:0], [brightness:0.9, saturation:0.27, kelvin:3250, hue:31, zone:1], [brightness:0.9, saturation:0.18, kelvin:3000, hue:20, zone:2], [brightness:0.9, saturation:0.09, kelvin:2750, hue:10, zone:3], [brightness:0.9, saturation:0, kelvin:2500, hue:329, zone:4], [brightness:0.9, saturation:0, kelvin:4125, hue:331, zone:5], [brightness:0.9, saturation:0, kelvin:5750, hue:332, zone:6], [brightness:0.9, saturation:0, kelvin:7375, hue:333, zone:7], [brightness:0.9, saturation:0, kelvin:9000, hue:333.99, zone:8], [brightness:0.9, saturation:0.09, kelvin:7625, hue:354, zone:9], [brightness:0.9, saturation:0.19, kelvin:6250, hue:348, zone:10], [brightness:0.9, saturation:0.28, kelvin:4875, hue:343, zone:11], [brightness:0.9, saturation:0.38, kelvin:3500, hue:337, zone:12], [br...[TRUNCATED] fe43e554-ede5-472e-8fd3-c4a367713a74 11:55:34: debug LIFX-GoG -- Kitchen Lights Group -- Response received from LFIX in the getReponseHandler. fe43e554-ede5-472e-8fd3-c4a367713a74 11:55:32: debug LIFX-GoG -- Kitchen Lights Group -- Polling... fe43e554-ede5-472e-8fd3-c4a367713a74 11:54:32: debug LIFX-GoG -- Kitchen Lights Group -- Response [[product:[company:LIFX, name:LIFX GU10, capabilities:[max_kelvin:9000, has_multizone:false, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_gu10], brightness:0.8999923704890517, id:d073d530ce61, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0, kelvin:9000, hue:49.9995422293431], connected:true, power:on, label:Kitchen 97, uuid:021c6db3-1640-48e1-8f3c-3d1361a9a3d2, last_seen:2018-07-11T01:54:32Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], seconds_since_seen:0], [product:[company:LIFX, name:LIFX Z, capabilities:[max_kelvin:9000, has_multizone:true, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_z], brightness:0.8999923704890517, id:d073d5272af9, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0.359990844586862, kelvin:3500, hue:40.99610894941634], connected:true, power:on, label:Oven Strip, uuid:02d348e4-e29d-46ea-bb63-bb4501a890d3, last_seen:2018-07-11T01:54:32Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], zones:[count:14, zones:[[brightness:0.9, saturation:0.36, kelvin:3500, hue:41, zone:0], [brightness:0.9, saturation:0.27, kelvin:3250, hue:31, zone:1], [brightness:0.9, saturation:0.18, kelvin:3000, hue:20, zone:2], [brightness:0.9, saturation:0.09, kelvin:2750, hue:10, zone:3], [brightness:0.9, saturation:0, kelvin:2500, hue:329, zone:4], [brightness:0.9, saturation:0, kelvin:4125, hue:331, zone:5], [brightness:0.9, saturation:0, kelvin:5750, hue:332, zone:6], [brightness:0.9, saturation:0, kelvin:7375, hue:333, zone:7], [brightness:0.9, saturation:0, kelvin:9000, hue:333.99, zone:8], [brightness:0.9, saturation:0.09, kelvin:7625, hue:354, zone:9], [brightness:0.9, saturation:0.19, kelvin:6250, hue:348, zone:10], [brightness:0.9, saturation:0.28, kelvin:4875, hue:343, zone:11], [brightness:0.9, saturation:0.38, kelvin:3500, hue:337, zone:12], [br...[TRUNCATED] fe43e554-ede5-472e-8fd3-c4a367713a74 11:54:32: debug LIFX-GoG -- Kitchen Lights Group -- Response received from LFIX in the getReponseHandler. fe43e554-ede5-472e-8fd3-c4a367713a74 11:54:32: debug LIFX-GoG -- Kitchen Lights Group -- Polling... fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:48: info LIFX-GoG -- Kitchen Lights Group -- 5 of 5 bulbs returned ok. fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:48: debug LIFX-GoG -- Kitchen Lights Group -- Response = [results:[[id:d073d5272af9, status:ok, label:Oven Strip], [id:d073d530ce01, status:ok, label:Kitchen 58], [id:d073d530ce5b, status:ok, label:Kitchen 54], [id:d073d530ce61, status:ok, label:Kitchen 97], [id:d073d530fdcb, status:ok, label:Kitchen 74]]] fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:48: debug LIFX-GoG -- Kitchen Lights Group -- Response received from LFIX in the putReponseHandler. fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:48: debug LIFX-GoG -- Kitchen Lights Group -- Response received from LFIX in the putReponseHandler. fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:42: debug LIFX-GoG -- Kitchen Lights Group -- Begin setting groups level to null over 5 seconds. fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:33: debug LIFX-GoG -- Kitchen Lights Group -- Response [[product:[company:LIFX, name:LIFX GU10, capabilities:[max_kelvin:9000, has_multizone:false, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_gu10], brightness:0.8999923704890517, id:d073d530ce61, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0, kelvin:9000, hue:49.9995422293431], connected:true, power:on, label:Kitchen 97, uuid:021c6db3-1640-48e1-8f3c-3d1361a9a3d2, last_seen:2018-07-11T01:53:32Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], seconds_since_seen:0], [product:[company:LIFX, name:LIFX Z, capabilities:[max_kelvin:9000, has_multizone:true, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_z], brightness:0.8999923704890517, id:d073d5272af9, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0.359990844586862, kelvin:3500, hue:40.99610894941634], connected:true, power:on, label:Oven Strip, uuid:02d348e4-e29d-46ea-bb63-bb4501a890d3, last_seen:2018-07-11T01:53:32Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], zones:[count:14, zones:[[brightness:0.9, saturation:0.36, kelvin:3500, hue:41, zone:0], [brightness:0.9, saturation:0.27, kelvin:3250, hue:31, zone:1], [brightness:0.9, saturation:0.18, kelvin:3000, hue:20, zone:2], [brightness:0.9, saturation:0.09, kelvin:2750, hue:10, zone:3], [brightness:0.9, saturation:0, kelvin:2500, hue:329, zone:4], [brightness:0.9, saturation:0, kelvin:4125, hue:331, zone:5], [brightness:0.9, saturation:0, kelvin:5750, hue:332, zone:6], [brightness:0.9, saturation:0, kelvin:7375, hue:333, zone:7], [brightness:0.9, saturation:0, kelvin:9000, hue:333.99, zone:8], [brightness:0.9, saturation:0.09, kelvin:7625, hue:354, zone:9], [brightness:0.9, saturation:0.19, kelvin:6250, hue:348, zone:10], [brightness:0.9, saturation:0.28, kelvin:4875, hue:343, zone:11], [brightness:0.9, saturation:0.38, kelvin:3500, hue:337, zone:12], [br...[TRUNCATED] fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:33: debug LIFX-GoG -- Kitchen Lights Group -- Response received from LFIX in the getReponseHandler. fe43e554-ede5-472e-8fd3-c4a367713a74 11:53:32: debug LIFX-GoG -- Kitchen Lights Group -- Polling... fe43e554-ede5-472e-8fd3-c4a367713a74 11:52:33: debug LIFX-GoG -- Kitchen Lights Group -- Response [[product:[company:LIFX, name:LIFX GU10, capabilities:[max_kelvin:9000, has_multizone:false, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_gu10], brightness:0.8999923704890517, id:d073d530ce61, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0, kelvin:9000, hue:49.9995422293431], connected:true, power:on, label:Kitchen 97, uuid:021c6db3-1640-48e1-8f3c-3d1361a9a3d2, last_seen:2018-07-11T01:52:32Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], seconds_since_seen:0], [product:[company:LIFX, name:LIFX Z, capabilities:[max_kelvin:9000, has_multizone:true, has_variable_color_temp:true, min_kelvin:2500, has_chain:false, has_ir:false, has_color:true], identifier:lifx_z], brightness:0.8999923704890517, id:d073d5272af9, location:[id:8178245e84ddcf5fca68d99958c3725f, name:My Home], color:[saturation:0.359990844586862, kelvin:3500, hue:40.99610894941634], connected:true, power:on, label:Oven Strip, uuid:02d348e4-e29d-46ea-bb63-bb4501a890d3, last_seen:2018-07-11T01:52:32Z, group:[id:80ffdd62f45f92acce8c2b2ca4782e5f, name:Kitchen], zones:[count:14, zones:[[brightness:0.9, saturation:0.36, kelvin:3500, hue:41, zone:0], [brightness:0.9, saturation:0.27, kelvin:3250, hue:31, zone:1], [brightness:0.9, saturation:0.18, kelvin:3000, hue:20, zone:2], [brightness:0.9, saturation:0.09, kelvin:2750, hue:10, zone:3], [brightness:0.9, saturation:0, kelvin:2500, hue:329, zone:4], [brightness:0.9, saturation:0, kelvin:4125, hue:331, zone:5], [brightness:0.9, saturation:0, kelvin:5750, hue:332, zone:6], [brightness:0.9, saturation:0, kelvin:7375, hue:333, zone:7], [brightness:0, saturation:0, kelvin:9000, hue:333.99, zone:8], [brightness:0, saturation:0.09, kelvin:7625, hue:354, zone:9], [brightness:0, saturation:0.19, kelvin:6250, hue:348, zone:10], [brightness:0, saturation:0.28, kelvin:4875, hue:343, zone:11], [brightness:0, saturation:0.38, kelvin:3500, hue:337, zone:12], [brightness:0...[TRUNCATED] fe43e554-ede5-472e-8fd3-c4a367713a74 11:52:33: debug LIFX-GoG -- Kitchen Lights Group -- Response received from LFIX in the getReponseHandler. fe43e554-ede5-472e-8fd3-c4a367713a74 11:52:32: debug LIFX-GoG -- Kitchen Lights Group -- Polling... fe43e554-ede5-472e-8fd3-c4a367713a74 11:52:19: info LIFX-GoG -- Kitchen Lights Group -- 5 of 5 bulbs returned ok. fe43e554-ede5-472e-8fd3-c4a367713a74 11:52:19: debug LIFX-GoG -- Kitchen Lights Group -- Response = [results:[[id:d073d5272af9, status:ok, label:Oven Strip], [id:d073d530ce01, status:ok, label:Kitchen 58], [id:d073d530ce5b, status:ok, label:Kitchen 54], [id:d073d530ce61, status:ok, label:Kitchen 97], [id:d073d530fdcb, status:ok, label:Kitchen 74]]] fe43e554-ede5-472e-8fd3-c4a367713a74 11:52:19: debug LIFX-GoG -- Kitchen Lights Group -- Response received from LFIX in the putReponseHandler. fe43e554-ede5-472e-8fd3-c4a367713a74 11:52:18: info LIFX-GoG -- Kitchen Lights Group -- Turning on...

joelegg commented 6 years ago

logs there just in case though. Will try new code - thank you!

ericvitale commented 6 years ago

Try now, 1.3.6 is up. I'll also take a look at the logs.

ericvitale commented 6 years ago

Any luck?

joelegg commented 6 years ago

It seems to be working now. If you have different settings for on off and state transition some lights in the group don't work. But if same it's fine.

Thank you !

On Thu., 12 Jul. 2018, 11:30 pm ericvitale, notifications@github.com wrote:

Any luck?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericvitale/ST-LIFX-Group-of-Groups/issues/1#issuecomment-404512590, or mute the thread https://github.com/notifications/unsubscribe-auth/AD62IhJ1HeoGjwLpZwrxbwUcN8219yO2ks5uF096gaJpZM4VKHcn .