search

ericvsmith / dataclasses

Apache License 2.0
587 stars 53 forks source link

Fix "dataclasses.replace broken if a class has any ClassVars" in backport #143

Closed gnillev closed 4 years ago

gnillev commented 5 years ago

This bug https://bugs.python.org/issue33796 is still present in version 0.6 of the backport. It would be nice to have a new backport version with the fix included.

AstraLuma commented 5 years ago

Bump, ran into this in ppb-vector.

anthrotype commented 4 years ago

@ericvsmith can we please have a new release of dataclasses backport with the fix in https://github.com/ericvsmith/dataclasses/pull/140 for ClassVar and .replace()? Thank you!!!

anthrotype commented 4 years ago

@ericvsmith Can you please cut a new release with #140 included? I need to use ClassVars with dataclasses and this prevents me from supporting python 3.6... I'm tempted to drop support for it altogether.

ericvsmith commented 4 years ago

@anthrotype : I've pushed 0.8 to PyPI. Please take a look.

anthrotype commented 4 years ago

now it works! thank you very much 👍

ericvsmith commented 4 years ago

No problem. Sorry for the extensive delay.