search

ericvsmith / dataclasses

Apache License 2.0
587 stars 53 forks source link

Update dataclasses.py #177

Closed angie8215 closed 4 months ago

angie8215 commented 4 months ago

Change is made at line 550, the underscore is removed.

ericvsmith commented 4 months ago

Why? What problem is being solved?

This code only targets python 3.6, and is generally unmaintained.

angie8215 commented 4 months ago

I get an error on line 550 because of the underscore: typing._ClassVar, when I removed it my project works correctly.

El jue, 11 de jul de 2024, 11:42 a. m., Eric V. Smith < @.***> escribió:

Why? What problem is being solved?

This code only targets python 3.6, and is generally unmaintained.

— Reply to this email directly, view it on GitHub https://github.com/ericvsmith/dataclasses/pull/177#issuecomment-2223520627, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJTHWQOK23ESM5AOKOZC2BLZL27XXAVCNFSM6AAAAABKXJYNTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRTGUZDANRSG4 . You are receiving this because you authored the thread.Message ID: @.***>

ericvsmith commented 4 months ago

Please follow advice like https://clickup.com/blog/how-to-write-a-bug-report/ on how to file a good bug report. You have not provided nearly enough information for anyone to help you.

angie8215 commented 4 months ago

My job is to implement CI/CD with gitlab and automate unit tests. Buildout for Odoo is being used. When installing the required libraries, it asks me for dataclasses version 0.8. However, when running the unit tests with green, I get the following error: [image: image.png] By directly removing that underscore from the library's dataclasses.py file, my project runs without problem.

El jue, 11 jul 2024 a las 19:10, Eric V. Smith @.***>) escribió:

Please follow advice like https://clickup.com/blog/how-to-write-a-bug-report/ on how to file a good bug report. You have not provided nearly enough information for anyone to help you.

— Reply to this email directly, view it on GitHub https://github.com/ericvsmith/dataclasses/pull/177#issuecomment-2224242212, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJTHWQLI3YWJNU4BPT6RA5DZL4UI7AVCNFSM6AAAAABKXJYNTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUGI2DEMRRGI . You are receiving this because you authored the thread.Message ID: @.***>

ericvsmith commented 4 months ago

You still have not provided enough information for anyone to reproduce your issue. I'm going to close this.