search

ericwbailey / a11y-webring.club

🌐 A webring for digital accessibility practitioners.
https://a11y-webring.club/
MIT License
39 stars 87 forks source link

Add github action to make sure webring builds #140

Closed sivakusayan closed 1 year ago

sivakusayan commented 1 year ago

This should fix #124.

As an aside, I had to bump the netlify-cli package to get around an EBADPLATFORM issue that would occur when installing the dependencies with npm ci. I hope this is OK, but let me know if it's not and I can try figuring another way around it.

How I tested

I used the act repo to test this action locally, but you can test this in any way you like.

  1. Introduce some error in the data/members folder (I just deleted a comma from a random JSON file).
  2. Verify that running the GitHub action fails.
  3. Remove the error introduced in step 1.
  4. Verify that running the GitHub action succeeds.
ericwbailey commented 1 year ago

I think this should be great! Thank you for taking the time to make and test this, it's really appreciated.

ericwbailey commented 1 year ago

Just wanted to say thank you again for adding this functionality. I've added a few new members in and it works like a charm 🙂