ericwilligers / svg-animation

Implement SVG animation in JavaScript using Web Animations
Apache License 2.0
120 stars 20 forks source link

llustrate the use of min and max #7

Closed ewilligers closed 10 years ago

ewilligers commented 10 years ago

min and max constrain the duration of an animation.

(max=indefinite has no effect, as does min=0.)

mithro commented 10 years ago

Would be good to add "Adding test which..." or something like that to the description?

Spelling mistake in the title s/Ilustrate/Illustrate/

I don't really understand SVG animations enough to verify this test at all.

ericwilligers commented 10 years ago

The test is now explained in the change description.

mithro commented 10 years ago

Do you want someone to verify the test? Or are you happy to just merge it?

mithro commented 10 years ago

LGTM then!