search

ericwoodruff / passwordhasherplus

Password Hasher Plus
http://goo.gl/LyLk3
Other
12 stars 21 forks source link

Include db backup in portable html page #20

Closed wkenyon closed 10 years ago

wkenyon commented 10 years ago

Problem

Every time I bump a site tag, I need to do two things:

This is a pain, it's duplicated work.

Solution

Include a backup of the database in the portable html file. Now I only need to do one thing: download a new version of the portable html file.

Security Concerns

Isn't it a bad idea to store the whole database in the portable html file? No, the whole database is already in there. It's just not in the same format as it needs to be to import on the options page.

Usability Concerns

Doesn't this clutter up the portable html page? Err... Maybe... I don't know.

ericwoodruff commented 10 years ago

I like this

ericwoodruff commented 10 years ago

I merged this in because that was the lazy way to test it. However, when I download the portable page and reveal the database it is empty.

ericwoodruff commented 10 years ago

It may be better to consolidate all of the json data elements into one that is essentially the dump of the whole database because then it would serve both purposes.

wkenyon commented 10 years ago

I'm having a look at doing that now.

ericwoodruff commented 10 years ago

Ok, cool.

wkenyon commented 10 years ago

See #21 for a pull request which fixes the problem.