search

ericwoodruff / passwordhasherplus

Password Hasher Plus
http://goo.gl/LyLk3
Other
12 stars 21 forks source link

Site tags changed #22

Open turkeyphant opened 10 years ago

turkeyphant commented 10 years ago

Site tags now ignore the TLD and cannot be changed.

ericwoodruff commented 10 years ago

Can you provide a more specific example?

turkeyphant commented 10 years ago

a) instead of "website.tld" it's just "website". b) when I click the extension button to manually change the tag, it instantly reverts.

ericwoodruff commented 10 years ago

a) This is by design. A recent pull-request enhanced this to use a smarter library to guess the root domain minus the tld. b) But it is supposed to remember what was used, and certainly let you change it.

turkeyphant commented 10 years ago

a) This completely breaks any pretence at being compatible with the original. Why would you want this? Can you fork to make it work with Firefox or at least add an option? b) Please advise of steps to reproduce correct functionality.

ericwoodruff commented 10 years ago

I have verified that I can change the tag for any site to whatever, so that is still working. You should be able to just re-add the rest of the tld to update the tag name. There should also be the old tag name in the autocomplete history to help with that.

But I agree, picking the right tag is no good when it is the wrong tag. I think it could guess based on the tag history not to use the new version.

turkeyphant commented 10 years ago

Please advise of steps.

ericwoodruff commented 10 years ago

When you click on the # icon to edit the tag the other options should popup when typing.

turkeyphant commented 10 years ago

Any changes made are not permanent and need to be changed every time. That's the bug.

ericwoodruff commented 9 years ago

Try making a change to the password length (even changing it back) and see if it takes