Closed scriptPilot closed 1 year ago
Hey, thanks for the offer but taking over the project is not my intention. But it was helpful and I tried to give a bit back by fixing issues I had during installation and hosting. Well, the reason for Docker were issues with Node one the one hand. But on the other hand I am trying to use Docker more frequently and not directly Node to avoid issues like these with different environments for different projects. PhantomJS was another issue where I made a workaround for and then some file management to streamline the installation process.
@scriptPilot in fine with this change but I still don't understand why phantomjs was added. As far as I know it isn't used in the project at all. I'd prefer to remove that before meeting since it's a large dependency that isn't even used by the project
While I followed the installation instruction, I got an error with PhantomJs and found that workaround.
If it is not installed before, there will be an error on npm install
.
So maybe it is used by your project as a sub dependency?
oh wow @scriptPilot you're right, the gulp script which converts SVGs to PNGs uses phantomjs under the hood 🤯
Ok I'll go ahead and merge this, I don't see anything damaging here. I didn't really test it but since the main changes are to the build process I don't see any real risk
Cool. Hopefully that will support users in the future to save some time 🥳
Very helpful software - thanks a lot. I discovered some issues while installation, build and deployment on iOS. This commit has fixed all of them. To allow the very old Node v8, I made use of Docker.