search

ericyd / gdrive-copy

Web app to copy a Google Drive folder
https://script.google.com/macros/s/AKfycbxbGNGajrxv-HbX2sVY2OTu7yj9VvxlOMOeQblZFuq7rYm7uyo/exec
MIT License
1.58k stars 343 forks source link

Please add mapnames and links to copylog #60

Closed AsIAmP closed 5 years ago

AsIAmP commented 5 years ago

Hi Eric, I am requesting a feature

What is the current behavior?

In the copy log names of files and links are provided

What is the needed behavior?

Please add a column with the link to the map and a column with the name of the map the file is in

This way the copylog can also act a an initial table of contents, and be sorted on map structure. I think this would be great to check content in quick way.

Thanks Pim

ericyd commented 5 years ago

Can you specify what you mean by a "link to the map"? I'm guessing you want some way to correlate the new file/folder to the old file/folder? The map that is used internally is just a huge javascript object, I don't think there is a great way to surface that in a way that has a pleasant UX. But, it would be pretty easy to add a column for "old file link" if that would suit your needs.

AsIAmP commented 5 years ago

For the new location of the file the URL of the destination map (the new location) and also the name of that map. Rationale: When copying a substantial treestructure with 2 levels of submaps you don't have a clue what it looks like and how the files are structured.

Thanks!

⁣Verzonden door BlueMail ​

Op 27 nov. 2018 04:06, om 04:06, Eric Yancey Dauenhauer notifications@github.com schreef:

Can you specify what you mean by a "link to the map"? I'm guessing you want some way to correlate the new file/folder to the old file/folder? The map that is used internally is just a huge javascript object, I don't think there is a great way to surface that in a way that has a pleasant UX. But, it would be pretty easy to add a column for "old file link" if that would suit your needs.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/ericyd/gdrive-copy/issues/60#issuecomment-441882033

ericyd commented 5 years ago

I'm still not following what you are requesting. The copy log already includes a link to the new file location. Can you be more specific about what you want me to add? I'm not clear what you mean by a map name.

AsIAmP commented 5 years ago

Hi Eric, Please have a look at this file, new exampledata links are clickable. https://docs.google.com/spreadsheets/d/1OfSs0Kks92qC8Ao74OuWSOgMwtOnd3CdIdGYGPHJe8Q/edit#gid=0

Met vriendelijke groet, Pim Holtz tel 06-12 18 24 71

Op di 27 nov. 2018 om 16:35 schreef Eric Yancey Dauenhauer < notifications@github.com>:

I'm still not following what you are requesting. The copy log already includes a link to the new file location. Can you be more specific about what you want me to add? I'm not clear what you mean by a map name.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericyd/gdrive-copy/issues/60#issuecomment-442102791, or mute the thread https://github.com/notifications/unsubscribe-auth/ArNa8MMj3XmMR_BCwD8WArmWT-aL0AYBks5uzVu5gaJpZM4YxWjo .

ericyd commented 5 years ago

Ok, so it looks like there are a few things going on here

  1. I am using the HYPERLINK Google Sheets formula to make a link to the file. It looks like this uses either a comma or semicolon delimiter based on locale, and if you're in the wrong one it will create a parse error which is what you're seeing. So, the ERROR text in your example sheet is actually supposed to be a hyperlink, I just didn't realize that it would break in different locations. I can fix that, I'll just put the URL and then the file name separately

  2. From your example, it looks like you want me to include a link to the parent folder of the file. Is that correct? I'm not sure I see the benefit of writing "Map for Eric" next to every file, but I could see it being helpful to have a link to the parent folder.

As for implementation, number 1 is very easy and number 2 is potentially more challenging, I need to look at the code more.

AsIAmP commented 5 years ago

Ad 1. That would be a good thing to do. Ad 2. The 'Map for Eric' is just the name of the parent folder. When having multiple directories this makes it easier to interpret where the file is located, so if it is possible that would be great to have as it allows for easier interpretation of the location. I believe the order of the copy is not always per map. So having the name would provide for easier sorting too. (I am not asking for sorting, I can do that myself)

I certainly hope that you can consider providing these changes. Thanks, kind regards, Pim Holtz

Op di 27 nov. 2018 om 19:40 schreef Eric Yancey Dauenhauer < notifications@github.com>:

Ok, so it looks like there are a few things going on here

1.

I am using the HYPERLINK Google Sheets formula to make a link to the file. It looks like this uses either a comma or semicolon delimiter based on locale, and if you're in the wrong one it will create a parse error which is what you're seeing. So, the ERROR text in your example sheet is actually supposed to be a hyperlink, I just didn't realize that it would break in different locations. I can fix that, I'll just put the URL and then the file name separately 2.

From your example, it looks like you want me to include a link to the parent folder of the file. Is that correct? I'm not sure I see the benefit of writing "Map for Eric" next to every file, but I could see it being helpful to have a link to the parent folder.

As for implementation, number 1 is very easy and number 2 is potentially more challenging, I need to look at the code more.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericyd/gdrive-copy/issues/60#issuecomment-442169740, or mute the thread https://github.com/notifications/unsubscribe-auth/ArNa8PgbzvnjXNDzNLS1K8NNqGMbQzGPks5uzYcSgaJpZM4YxWjo .

ericyd commented 5 years ago

I fixed the links in the Copy Log and included a link to the Parent folder, so I'm going to close this.

I created a new issue #61 to add the parent folder name. I think this is a good idea but will take some more development effort and I don't have lots of time to spend on this project these days.

AsIAmP commented 5 years ago

Great, thank you so much for your fast reaction. Have a good day!

Op za 1 dec. 2018 om 22:26 schreef Eric Yancey Dauenhauer < notifications@github.com>:

I fixed the links in the Copy Log and included a link to the Parent folder, so I'm going to close this.

I created a new issue #61 https://github.com/ericyd/gdrive-copy/issues/61 to add the parent folder name. I think this is a good idea but will take some more development effort and I don't have lots of time to spend on this project these days.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericyd/gdrive-copy/issues/60#issuecomment-443459791, or mute the thread https://github.com/notifications/unsubscribe-auth/ArNa8JEwvcdE88N9mtUR-MU0vpQdiWqiks5u0vQLgaJpZM4YxWjo .