search

ericyd / gdrive-copy

Web app to copy a Google Drive folder
https://script.google.com/macros/s/AKfycbxbGNGajrxv-HbX2sVY2OTu7yj9VvxlOMOeQblZFuq7rYm7uyo/exec
MIT License
1.58k stars 343 forks source link

Fix build pipeline #90

Closed ericyd closed 5 years ago

ericyd commented 5 years ago

Closes #88

Verify that #92 is not introduced with this PR, or if so, fix before deployment

If revert is needed, use this version of application.gs https://github.com/ericyd/gdrive-copy/blob/66cb51c07980628d31a0578268fd7ab65157f31e/dist/application.gs

sbwoodside commented 5 years ago

I decided to try rebuilding everything from scratch, and actually I'm doing it on a new Mac as well.

I'm getting two build errors:

First, when doing npm i I get an error installing gyp, although it doesn't fail the whole install.

Second, when I subsequently do npm run build:prod I get an error from gulp:

``gulp[6479]: ../src/node_contextify.cc:640:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertionargs[1]->IsString()' failed.



Full log: [log.txt](https://github.com/ericyd/gdrive-copy/files/2990070/log.txt)

Let me know if you want me to open a separate ticket for this.
ericyd commented 5 years ago

No ticket needed, just use Node 8 as indicated in the readme