erigontech / erigon

Ethereum implementation on the efficiency frontier https://erigon.gitbook.io
GNU Lesser General Public License v3.0
3.1k stars 1.09k forks source link

Unify docker builds #10251

Closed yperbasis closed 5 days ago

yperbasis commented 4 months ago

For instance, v2.60.0-rc1 is available in 3 flavours: thorax/erigon:2.60.0-rc1-arm64, thorax/erigon:2.60.0-rc1-amd64, thorax/erigon:v2.60.0-rc1. Those can probably be combined into one. Side note: the arm64/amd64 flavours are significantly smaller (30 MB vs 487MB).

Alex Sharov: "hub.docker.com now building for: docker_{\1} branches, and all tags, and main branch as latest tag. And probably it doesn't produce multi-arch images - maybe it already can - i don't know

our .release.ymltriggered from .github/workflow/release.yml and it does cross-compilation (while hub.docker.com doesn't).

Some people did try add more binaries and more archs https://github.com/ledgerwatch/erigon/pull/7912/files#diff-42e26dc67aed8aa3edb2472b4403288c1699fb6dc47419b9a475f0f224fe4689L68 - but i don't know how to review this change πŸ™‚ and don't want support so many archs (how will download from github all this binaries).

goreleaser has many features - like publish in homebrew or apt. also alway was lazy to add it."

See also Issues #7893 & #10023 and PR #7912.

yperbasis commented 3 months ago

Bumping the priority because Gnosis (Philippe Schommers) said that we should pay more attention to our releases on Docker because it is fundamental to the Gnosis ecosystem.

somnathb1 commented 3 months ago

For homebrew there is also: https://github.com/Homebrew/homebrew-core/blob/master/Formula/e/erigon.rb, https://formulae.brew.sh/formula/erigon

Which isn't in use now, probably. But used to be pretty good when I was on macOS back in the day

michelemodolo commented 2 months ago

Assigning to you @lystopad

lystopad commented 5 days ago

I implemented multi-platform docker builds for releases as well as docker image releases for new commits in main branch. Closing this issue as resolved.