search

erigontech / erigon

Ethereum implementation on the efficiency frontier https://erigon.gitbook.io
GNU Lesser General Public License v3.0
3.14k stars 1.12k forks source link

re-introduce: `state.NewCachedReader` #10747

Closed AskAlexSharov closed 1 month ago

AskAlexSharov commented 4 months ago

we stoped use it here https://github.com/ledgerwatch/erigon/pull/10746 , because of bug (I think reason is: 1. StateCache works on incarnation and 2. Need delete all storage when delete account) https://github.com/ledgerwatch/erigon/issues/10444 But we don't know perf impact of cache. Need carefully re-introduce it and bench speed.

Of-course such cache will be useful for "remote rpcdaemon deploy", but it's rare.

Maybe cache need a bit change to use Domain concept. (not sure)

AskAlexSharov commented 2 months ago

not so important after adding: ii_lru but ii_lru works on low-level and not helpful over grpc (remote rpcdaemon)

AskAlexSharov commented 1 month ago

done