search

erigontech / erigon

Ethereum implementation on the efficiency frontier https://erigon.gitbook.io
GNU Lesser General Public License v3.0
3.14k stars 1.13k forks source link

fix checkpoints/list heimdall API not returning "id" (on heimdall side and tidy up our workaround) #11169

Open taratorio opened 3 months ago

taratorio commented 3 months ago
  1. open a PR on the heimdall repo to include the "id" field for checkpoints
  2. after that has been released to users (via the heimdall release process) + waiting a few months for all users to upgrade to heimdall versions containing that fix we can then remove the workaround in our heimdall service to not set the "id" (in the batch fetch checkpoints logic that uses the checkpoints/list api)

for context, these are the workarounds we had to do:

shohamc1 commented 2 months ago

https://github.com/maticnetwork/heimdall/pull/1183