erigontech / erigon

Ethereum implementation on the efficiency frontier https://erigon.gitbook.io
GNU Lesser General Public License v3.0
3.15k stars 1.13k forks source link

e3: RangeAsOf (history.RangeAsOf) should skip empty vals #12736

Open JkLondon opened 1 week ago

JkLondon commented 1 week ago

now we return lots of empty vals during the iteration. It is unused and should be fixed

awskii commented 3 days ago

first empty value means key was created, following nil's mean deletion at given txnum. Maybe more specific value should be returned in that case so we would know that 'value has been created here' and then 'has been removed here' without stacking nils or computing oddness

AskAlexSharov commented 3 days ago

For history: it’s ok to return empry values For domain.RangeAsOf: not