search

erigontech / erigon

Ethereum implementation on the efficiency frontier https://erigon.gitbook.io
GNU Lesser General Public License v3.0
3.09k stars 1.08k forks source link

Remove Dockerfile.release #7893

Open AskAlexSharov opened 1 year ago

AskAlexSharov commented 1 year ago

Reason: 1 dockerfile is enough and now Dockerfile.release has only erigon binary (reason of https://github.com/ledgerwatch/erigon/issues/7847 )

  1. remove Dockerfile.release - use only Dockerfile
  2. in .goreleaser.yml replace Dockerfile.release with just Dockerfile
  3. in .goreleaser.yml somehow need build ALL binaries (not only erigon) - maybe we can't implement it by some kind of wildcard? It's ok that 1 docker image has all binaries - user still can run them as separated containers (same as our docker-compose.yml does)
  4. test that docker compose up -d works
  5. test that make release-dry-run and make release works
  6. test that CI action Release works. Here is how to run it manually:
Screenshot 2023-07-14 at 10 43 01

Other things:

  1. up golang version in Dockerifle.debian
  2. check that Dockerfile.debian and Dockerfile match each other (have same binaries or features)
github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

github-actions[bot] commented 11 months ago

This issue was closed because it has been stalled for 7 days with no activity.