search

erigontech / erigon

Ethereum implementation on the efficiency frontier https://erigon.gitbook.io
GNU Lesser General Public License v3.0
3.13k stars 1.11k forks source link

http and ws compression flag defaults are reversed #8471

Open quickchase opened 1 year ago

quickchase commented 1 year ago

In the output of erigon --help you see the following:

--http.compression                                       Enable compression over HTTP-RPC (default: false)
--ws.compression                                         Enable compression over WebSocket (default: false)

However, even without adding these flags they are enabled by default, as seen in the startup log:

HTTP endpoint opened                     url=[::]:8545 ws=true ws.compression=true grpc=false

Either this should actually default to false, or the help should be updated to reflect the inverse, similar to how --http=false works in that help output:

--http                                                   HTTP-RPC server (enabled by default). Use --http=false to disable it (default: true)

I believe the incorrect default is set here

Don't really have a strong preference for what the correct default is or correct behavior but help output is incorrect at the very least.

AskAlexSharov commented 1 year ago

Defaults can be compatible with geth