erik-krogh / SudoSlider

The most versatile jQuery content slider
36 stars 24 forks source link

Slider with 1 item more than slideCount acts different than multiple more #4

Closed jacob-v-dam closed 11 years ago

jacob-v-dam commented 11 years ago

Hello,

While developing I noticed a strange behavior.

I created a slide which would show 4 slides and slide these by 4 as well. But when I add more slides the previous and next button acts different. When I have 5 slides and clicking next the moveCount is ignored, but not with multiple slides.

Check this JSFiddle: http://jsfiddle.net/zMEkx/

Thanks, Jacob

webbiesdk commented 11 years ago

This might seem like weird behaviour but it is performing as intended.

What is happening in your JSFiddle is not that moveCount is ignored. When you are at slide 1 and press next, the slider goes to slide number 5. It then does some math (lines 1035 - 1048 in the script) to determine how to this while moving as little as possible, and it determines that the shortest way to go 4 slider forward, is to go one slide backwards. If you put numbers in the slide you can see that it ends up at slide number 5. http://jsfiddle.net/KBHnc/

I can see that this behaviour seems weird in some cases, do you think i should disable it?

jacob-v-dam commented 11 years ago

I think it should be optional, in this case I expected that the slider always would use right to left. What I also expected is that is would slide 4 slides since the move count is 4 and continuous is set.

webbiesdk commented 11 years ago

I'll disable it when you press "next" or "previous" in the next update of the script. For now you can disable it by changing the if on line 1034