search

erik-krogh / SudoSlider

The most versatile jQuery content slider
36 stars 24 forks source link

Changed jQuery calls from "$" to "jQuery" to improve WP compatibility #57

Closed kegles closed 7 years ago

webbiesdk commented 8 years ago

The only place where i can see that this could make a difference, is the one on line 33.

The rest are just renaming a local variable, so why would that help?

kegles commented 8 years ago

only to maintain the nomenclature

kegles commented 8 years ago

but replacing in all file add some bytes to plugin, is good replace only in line 33 :)

webbiesdk commented 8 years ago

I don't know if i completely get what it is you are saying.

But if you could change the pull-request, so that it only makes the change on line 33, that would be great. (You can also create a new pull-request, if that is easier).