search

erik-krogh / SudoSlider

The most versatile jQuery content slider
36 stars 24 forks source link

Problem with runOnImagesLoaded in 3.2.2 #8

Closed danyj closed 10 years ago

danyj commented 10 years ago

I am not sure how to demonstrate this but I have slides inside divs it is mixed content text , images etc

In 3.1.7 on any page load everything looks fine but latest version is adding height and width attributes to images inside the slides , if responsive is on the slide stays small but any image inside the slide is stretched

http://prntscr.com/2t31aq

line 649 if commented

$(that).height(that.naturalHeight).width(that.naturalWidth);

everything is ok

any suggestion?

webbiesdk commented 10 years ago

That line fixes something, i don't quite remember exactly what. And if i remove that line, i have to do some stuff in the ajaxLoad function, otherwise ajax loaded images are fucked in some browsers. I think that some of it was maybe only needed for previous versions of FireFox and Chrome, so maybe i can just remove them... I'm just thinking out loud.

TL;DR: I'm on it.

danyj commented 10 years ago

Thnx much for looking at it. How about activating it only if ajax option is requested?

webbiesdk commented 10 years ago

You can use Ajax mixed with non-Ajax content, so that wouldn't be a good fix. I'm currently testing removing all the ugly image fixes, seems to be working.

webbiesdk commented 10 years ago

All the ugly fixes as in 2. The one you found, and in loadImage() where i did funny stuff with images height/width.

webbiesdk commented 10 years ago

I just released 3.3.0, and i think the issue is fixed in that version.

I know its been a while, but I was working on getting touch to work with the slider, and that took a while (this is just a hobby).