erik / derive

Generate personal heatmap from GPX/TCX/FIT/IGC data
https://erik.github.io/derive
MIT License
490 stars 62 forks source link

Add Geotagged Image Support #14

Closed jbuckner closed 6 years ago

jbuckner commented 6 years ago

This adds support for dragging geotagged jpg images and puts markers on the map. When you click on the marker, you get a popup with the image.

It uses exif-js for EXIF parsing.

derive_image2

erik commented 6 years ago

Awesome, thanks for the PR!

I won't have time to review until after the weekend but the idea looks cool.

jbuckner commented 6 years ago

I think I got to all of the feedback. I had to add babel-polyfill to support async / await syntax. Man those are nice!

Unfortunately it looks like jshint doesn't support async / await yet so now Travis is failing. I'm seeing what options are available to fix this. It looks like there's a linter called eslint that supports it but I need to dig into this a bit more.

erik commented 6 years ago

Nice! Thanks for addressing our earlier comments.

This looks good to me, I can figure out switching over to eslint as a follow up PR, I've used eslint before and I'm fine migrating this project over to it.

jbuckner commented 6 years ago

Great, thanks! Let me merge master in and fix linting in my branch and I'll push.

erik commented 6 years ago

Oops, sorry for stepping on your toes there with the merge commit. But yeah, the errors at this point are style only, so we should be good to go after that 👍

jbuckner commented 6 years ago

No worries. I just fixed the last few lint issues so the next Travis run should be good.