search

erik78se / charm-gitlab-runner

A juju charm (hooks,bash) deploying gitlab-runner
Apache License 2.0
3 stars 1 forks source link

do we need sudo? #22

Open jamesbeedy opened 3 years ago

jamesbeedy commented 3 years ago

I'm thinking these hooks run as root, is there a reason to use sudo?

https://github.com/erik78se/charm-gitlab-runner/blob/b0030376ea053880e8fc4fb76a00c21d65685084/src/hooks/install#L11

erik78se commented 3 years ago

No, this is completely right and its removed in the operator version as this charm is mostly here for reference. Good spot.