erikanso / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Divs not wrapped around corresponding sections correctly #1

Open Emik234 opened 7 years ago

Emik234 commented 7 years ago

Whenever you are working on a website with different sections, it's common practice to group each section with a <div> or <section>. This will help keep things organized and allow us to style it in more ways.

Here's an example:

<div id="brushes">
        <h2>Brushes</h2>
        <img ...>
        <h3>...</h3>
        <p>...<span>...</span></p>
      </div>

With this, we can now style any element by using the unique id as a starting point for the css selectors, for instance, if you wanted to change the background color of the <h2> element, we can do so like this:

#brushes h2 {
        background-color: ...;
      }

So go ahead and make those changes for each section you have.

modify this:

https://github.com/erikanso/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L9-L26

To match this:

  <!-- Brushes Section -->

  <div class="item">
    <h2 id="brush">Brushes</h2>
    <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg"/>
    <h3>Hacksaw Brushes</h3>
    <p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <span class="price">Starting at $3.00 / brush.</span></p>
  </div>

  <!-- Frames Section -->

  <div class="item">
    <h2 id="frame">Frames</h2>
    <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/frames.jpeg"/>
    <h3>Art Frames (assorted)</h3>
    <p>Assorted frames made of different material, including MDF, birchwood, and PDE. Select frames can be sanded and painted according to your needs. <span class="price">Starting at $2.00 / frame.</span></p>
  </div>

  <!-- Paint Section -->

  <div class="item">
    <h2 id="paint">Paint</h2>
    <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/finnish.jpeg"/>
    <h3>Clean Finnish Paint</h3>
    <p>Imported paint from Finland. Over 256 colors available in-store, varying in quantity (1 oz. to 8 oz.). Clean Finnish paint microbinds to canvas, increasing the finish and longevity of any artwork. <span class="price">Starting at $5.00 / tube.</span>
  </div>
erikanso commented 7 years ago

I updated my format and tried the following syntax, but it seems redundant and actually prevents the background-color for each h2 from showing.

#brushes h2 { background-color: ...; }