search

erikanso / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #4

Closed Emik234 closed 7 years ago

Emik234 commented 7 years ago

Project name: Dasmoto Arts & Crafts Summary Grade: Satisfactory

Great job on the visual design of the site. It matched well and your indentation was great, making it easier to read the code.

The areas of improvement I would say is adding multi-line comments to better section out your HTML and CSS so that it’s easier to cross reference the selectors with the class names or ID’s in the event something needs to be modified. In addition, while you did well with divs, it was missing a specific pattern that it needed to be in I.e:

<div class="item">
     <h2 id="brush">Brushes</h2>
      <img ...> 
     <h3> </h3>
    <p> <span> </span></p>
  </div>

As a further challenge, consider adding a full background image. This will take some extra research but could be a really valuable way to challenge yourself to push past what you’ve already learned. Based on your work here, I think it’s a challenge you’re ready for.

erikanso commented 7 years ago

Thanks for the detailed feedback! Good to know that you can add an "id" within a header element.