search

erikarn / athp

freebsd ath10k port
47 stars 15 forks source link

if_athp_mac.c errors, missing brackets, wrong variable declaration #2

Closed baos780 closed 7 years ago

baos780 commented 7 years ago

athp/athp-master/otus/freebsd/src/sys/modules/athp/../../dev/athp/if_athp_mac.c:3339:6: error: logical not is only applied to the left hand side of this bitwise operator [-Werror,-Wlogical-not-parentheses] if (!ni->ni_flags & IEEE80211_NODE_HT) ^ ~ Should probably be changed to: if (!(ni->ni_flags & IEEE80211_NODE_HT))

Error in ath10k_dbg call specifically referencing the j variable which is part of the loop iteration:

athp/athp-master/otus/freebsd/src/sys/modules/athp/../../dev/athp/if_athp_mac.c:3848:17: error: format specifies type 'ssize_t' (aka 'long') but the argument has type 'int' [-Werror,-Wformat] func, j, arg.n_channels,

erikarn commented 7 years ago

daww wish I had a pull request! let me fix this

erikarn commented 7 years ago

fixd, thanks!