Various cleanups - Githubissues

bzfbd commented 4 years ago

Some code cleanup.

Make sure we compile with and without INVARIANTS in the kernel config.
Properly indent a block.
Make the QUAD sysctls UQUAD as it is uint64_t type members.
Properly hide unused functions behind #if 0 rather than leaving an unused stub with a TODO printf. We can go back to that once we actually call them.
Do export not-really-static functions rather than having static prototypes in other files for them; how did that ever work properly?
Add missing if_pci.h to Makefile SRCS.

Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")

bzfbd commented 4 years ago

Hey, you picked the Makefile change out of these changes but most of the others are still not merged and given you moved forward there's some conflicts now. Would you apply them all if I once more make this compile? I'd really like not having to bother about INVARIANTS and WITNESS anymore and being able to compile a GENERIC-NODEBUG without warnings.

erikarn commented 4 years ago

I'm about to cherry pick in the invariants ones, yeah. Sorry, was neck deep in finishing my own lols. :-)

-adrian

On Tue, 16 Jun 2020 at 13:35, bzfbd notifications@github.com wrote:

Hey, you picked the Makefile change out of these changes but most of the others are still not merged and given you moved forward there's some conflicts now. Would you apply them all if I once more make this compile? I'd really like not having to bother about INVARIANTS and WITNESS anymore and being able to compile a GENERIC-NODEBUG without warnings.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/erikarn/athp/pull/35#issuecomment-644997879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI2L3KL5JILL6ZIZV2YSX3RW7JR5ANCNFSM4NSRBV2A .

erikarn / athp

Various cleanups #35